Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

I am java programmer and liked java culture. And I see nothing wrong with "foo".equals(someVariable).

If code review ends with lengthy explanation over why not use "foo".equals(someVariable) or some other maintenance/readability/effectivity/other important consideration non-affecting issue, I see something wrong with code review.



I agree... StringUtils is awesome, but "foo".equals(someVariable) is not a case where it's use is important.


In this case code review is actually the reviewer trying to boost ego and stamp authority on reviewee




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: